Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional PodDisruptionBudget to chart #1181

Closed
slushysnowman opened this issue Apr 26, 2022 · 2 comments
Closed

Add optional PodDisruptionBudget to chart #1181

slushysnowman opened this issue Apr 26, 2022 · 2 comments

Comments

@slushysnowman
Copy link

Currently, there is no option to create PodDisruptionBudget in the chart. It would be very handy to have the option to do this from within the chart, so that users who require a PodDisruptionBudget don't have to maintain this separately.

@zyyw
Copy link
Collaborator

zyyw commented May 5, 2022

Since the PDB is a relatively independent resource. We would suggest you manage PBD separately instead of incorporating with harbor-helm.

@zyyw zyyw closed this as completed May 5, 2022
@robinkb
Copy link

robinkb commented Oct 4, 2022

I disagree with this conclusion. I consume a lot of Helm charts in my environments, and most Helm charts which can setup highly-available applications include PDBs in the chart. Having to configure all of the matchLabels and such is a hassle that I would expect the Helm chart to do for me.

Having said that, I do think that the proposed PR (#1182) was not very elegant. My favorite implementation that I've seen so far is in the chart for oauth2-proxy. The PDBs are enabled by default, but only when the replicaCount is > 1.

PodDisruptionBudgets are essential to ensure that applications don't go down during normal cluster operations, like rolling restarts of nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants