Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add REGISTRY_HTTP_SECRET env for registry if .Values.registry.existingSecret is set #1646

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: add REGISTRY_HTTP_SECRET env for registry if .Values.registry.existingSecret is set #1646

merged 1 commit into from
Dec 19, 2023

Conversation

zyyw
Copy link
Collaborator

@zyyw zyyw commented Nov 29, 2023

Fix: #1644

@zyyw
fix: add REGISTRY_HTTP_SECRET env for registry if .Values.registry.ex…
71297fd 
…istingSecret is set

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
MinerYang
MinerYang approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit d32655c into goharbor:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywk253100 ywk253100 ywk253100 approved these changes

@MinerYang MinerYang MinerYang approved these changes

Assignees

@ywk253100 ywk253100

@MinerYang MinerYang

Labels
target/1.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

registry.existingSecret is only set on registryctl container, not registry.
3 participants
@zyyw @ywk253100 @MinerYang