add registry.relativeurls value #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablo-ruth
changed the title
|
Hi, any updates on this? |
|
I need this too, because same error occurs when running the registry on non default port. So this fix would help. |
|
@pablo-ruth Could you resolve the conflict? |
ywk253100
reviewed
Sep 17, 2019
|
Ok done :) |
ywk253100
approved these changes
Sep 18, 2019
|
@pablo-ruth Could you squash all commits into a single one? |
Signed-off-by: Pablo RUTH <contact@pablo-ruth.fr>
|
Done, commits are squashed |
|
@pablo-ruth Thanks! |
|
ISTM that this needs to be back-ported to the component that generates ref #174 (comment) |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a value to config relativeurls support on registry. This is needed when expose.type is not set to ingress to avoid "unkown blob" error on image push.
Resolves #174