fix: ci error

Signed-off-by: soulseen <zhuxiaoyang1996@gmail.com>

pkg/cluster/controllers/storage/provision.go

@@ -147,7 +147,10 @@ func (m *MinIOController) Provision() (*lcm.CRStatus, error) {
 
 	// expose minIO access endpoint by ingress.
 	if m.HarborCluster.Spec.InClusterStorage.MinIOSpec.Redirect.Disable {
-		ingress := m.generateIngress()
+		ingress, err := m.generateIngress()
+		if err != nil {
+			return minioNotReadyStatus(CreateMinIOIngressError, err.Error()), err
+		}
 
 		err = m.KubeClient.Create(ingress)
 		if err != nil && !k8serror.IsAlreadyExists(err) {
@@ -167,7 +170,7 @@ func (m *MinIOController) Provision() (*lcm.CRStatus, error) {
 	return minioUnknownStatus(), nil
 }
 
-func (m *MinIOController) generateIngress() *netv1.Ingress {
+func (m *MinIOController) generateIngress() (*netv1.Ingress, error) {
 	var tls []netv1.IngressTLS
 
 	if m.HarborCluster.Spec.InClusterStorage.MinIOSpec.Redirect.TLS.Enabled() {

pkg/cluster/controllers/storage/update.go

@@ -29,31 +29,34 @@ func (m *MinIOController) checkRedirectUpdate() (bool, error) {
 		return false, err
 	}
 
-	desiredingress := m.generateIngress()
+	desiredingress, err := m.generateIngress()
 
 	if currntIngress.Spec.Rules[0].Host != desiredingress.Spec.Rules[0].Host {
-		return true, nil
+		return true, err
 	}
 
 	if currntIngress.Spec.Rules[0].IngressRuleValue.HTTP.Paths[0] != desiredingress.Spec.Rules[0].IngressRuleValue.HTTP.Paths[0] {
-		return true, nil
+		return true, err
 	}
 
 	if currntIngress.Spec.TLS[0].Hosts[0] != desiredingress.Spec.TLS[0].Hosts[0] {
-		return true, nil
+		return true, err
 	}
 
 	if currntIngress.Spec.TLS[0].SecretName != desiredingress.Spec.TLS[0].SecretName {
-		return true, nil
+		return true, err
 	}
 
-	return false, nil
+	return false, err
 }
 
 func (m *MinIOController) updateMinioIngress() error {
-	desiredingress := m.generateIngress()
+	desiredingress, err := m.generateIngress()
+	if err != nil {
+		return err
+	}
 
-	err := m.KubeClient.Update(desiredingress)
+	err = m.KubeClient.Update(desiredingress)
 	if err != nil {
 		return err
 	}