fix(status): fix ready condition in status.

refactor GetHealth method, using in-cluster service to get health.
goharbor · Sep 16, 2020 · fb081bd · fb081bd
1 parent 8656fc5
commit fb081bd
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/controllers/harbor/health.go b/controllers/harbor/health.go
@@ -59,12 +59,11 @@ func (h *APIHealth) GetUnhealthyComponents() []string {
 }
 
 func (r *Reconciler) GetHealth(ctx context.Context, harbor *goharborv1alpha1.Harbor) (*APIHealth, error) {
-	span, ctx := opentracing.StartSpanFromContext(ctx, "check")
+	span, _ := opentracing.StartSpanFromContext(ctx, "check")
 	defer span.Finish()
 
 	// access in-cluster service
-	url := fmt.Sprintf("http://%s.%s%s", harbor.NormalizeComponentName(goharborv1alpha1.CoreName), harbor.GetNamespace(), HarborHealthEndpoint)
-	resp, err := http.Get(url)
+	resp, err := http.Get(fmt.Sprintf("http://%s.%s%s", harbor.NormalizeComponentName(goharborv1alpha1.CoreName), harbor.GetNamespace(), HarborHealthEndpoint))
 	if err != nil {
 		return nil, errors.Wrap(err, "cannot get health response")
 	}