Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CI/CD pipeline with github action #3

Closed
steven-zou opened this issue Mar 11, 2020 · 2 comments · Fixed by #13 or #22
Closed

Enable CI/CD pipeline with github action #3

steven-zou opened this issue Mar 11, 2020 · 2 comments · Fixed by #13 or #22
Assignees
@holyhope
Labels
area/CICD Issues for CI/CD kind/requirement New feature or request release/0.5 Issues for the release 0.5

Comments

@steven-zou
Copy link
Collaborator

Cover:

  • CODE (lint, vet, race )
  • UT
  • Verify if it can work well in cluster (kind/minikube etc.）
@steven-zou steven-zou added release/0.5 Issues for the release 0.5 area/CICD Issues for CI/CD kind/requirement New feature or request labels Mar 11, 2020
@holyhope holyhope self-assigned this Mar 13, 2020
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add linter on push #3
2313db0
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add linters github actions. Fix #3
956a5a8
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add linters github actions. Fix #3
5198425
@holyhope holyhope mentioned this issue Mar 13, 2020
Merged
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add github actions. Fix #3
67bfa1e 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add github actions. Fix #3
82f68c7 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add github actions. Fix #3
d577fad 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add github actions. Fix #3
d1f4202 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add github actions. Fix #3
f2f395e 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add github actions. Fix #3
25cc4d9 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 13, 2020
@holyhope
ci(lint) Add github actions. Fix #3
3c70870 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 14, 2020
@holyhope
ci(lint) Add github actions. Fix #3
b4e16fe 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 14, 2020
@holyhope
ci(lint) Add github actions. Fix #3
64fa4fb 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 15, 2020
@holyhope
ci(lint) Add github actions. Fix #3
9cd2626 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 15, 2020
@holyhope
ci(lint) Add github actions. Fix #3
f23525c 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 15, 2020
@holyhope
ci(lint) Add github actions. Fix #3
07d6f2b 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 15, 2020
@holyhope
ci(lint) Add github actions. Fix #3
e0efd01 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 16, 2020
@holyhope
ci(lint) Add github actions. Fix #3
b1af55b 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 16, 2020
@holyhope
ci(lint) Add github actions. Fix #3
3fd6113 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 16, 2020
@holyhope
ci(lint) Add github actions. Fix #3
4d7b989 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 16, 2020
@holyhope
ci(lint) Add github actions. Fix #3
5ac7a9e 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
holyhope added a commit that referenced this issue Mar 16, 2020
@holyhope
ci(lint) Add github actions. Fix #3
74549a1 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
@holyhope holyhope mentioned this issue Mar 17, 2020
Closed
holyhope added a commit that referenced this issue Mar 17, 2020
@holyhope
ci(lint) Add github actions. Fix #3
d9c8192 
- linters: go, markdown, dockerfile
- golang: dependencies, generated files
- kubernetes: crd, default and samples validation
- build: docker

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
@holyhope
Copy link
Collaborator

Still missing unit tests and deployment tests

@holyhope holyhope reopened this Mar 19, 2020
@steven-zou
Copy link
Collaborator Author

Moreover, the GitHub action workflow should have one overall name, something like 'CI/CD'. Currently, I can see 4 action workflows.

You can check it in the Action tab.

@holyhope holyhope linked a pull request Mar 27, 2020 that will close this issue
feat(cd) Release and tests #22
Merged
MarcelMue pushed a commit that referenced this issue May 25, 2023
@DeeAjayi @CoderTH @zlangi
Add Redis service account name to CRD (#1001)
ba4d731 
* upgrade controller-runtime version (#1034)

upgrade controller runtime version

Signed-off-by: coderth <coderth@outlook.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>

* Add the missing github-cr proxy cache module (#1035)

Add the missing github proxy cache module

Signed-off-by: Zoltan Langi <zoltan.langi@gmail.com>
Co-authored-by: Zoltan Langi <zoltan.langi@gmail.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>

* Add service account name to cr (#3)

* Included Service Account to Redis CR

Signed-off-by: Oladipupo Ajayi <ajayidipo@ymail.com>

* Revert deployment change

Signed-off-by: Oladipupo Ajayi <ajayidipo@ymail.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>

---------

Signed-off-by: coderth <coderth@outlook.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>
Signed-off-by: Zoltan Langi <zoltan.langi@gmail.com>
Signed-off-by: Oladipupo Ajayi <ajayidipo@ymail.com>
Co-authored-by: Noah Tang <51119718+CoderTH@users.noreply.github.com>
Co-authored-by: Zoltan <36501500+zlangi@users.noreply.github.com>
Co-authored-by: Zoltan Langi <zoltan.langi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holyhope holyhope

Labels
area/CICD Issues for CI/CD kind/requirement New feature or request release/0.5 Issues for the release 0.5
Projects
None yet
Milestone
No milestone
2 participants
@holyhope @steven-zou