Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue found in the Harbor class #399

Closed
steven-zou opened this issue Jan 15, 2021 · 2 comments
Closed

Issue found in the Harbor class #399

steven-zou opened this issue Jan 15, 2021 · 2 comments
Assignees
@sguyennet @holyhope
Labels
kind/bug Something isn't working release/1.0 Issues for the release 1.0

Comments

@steven-zou
Copy link
Collaborator

No description provided.

@steven-zou steven-zou added kind/bug Something isn't working release/1.0 Issues for the release 1.0 labels Jan 15, 2021
@holyhope holyhope assigned holyhope and sguyennet and unassigned holyhope Jan 19, 2021
@holyhope
Copy link
Collaborator

When using harbor-class annotation, controllers do not watch the right resources.
Add tests for watching resources with owner with harbor-class.

Suggestion: When running tests, generate a harbor class name so multiple controllers may be started at the same time.

@sguyennet sguyennet changed the title Issue found in the Harbor class of ingresses Issue found in the Harbor class Jan 20, 2021
@holyhope
Copy link
Collaborator

Related packages

More information

The top-level resource (such as Harbor) is filtered with the annotation, what about child resources? Those children do not have annotation.

sguyennet added a commit to sguyennet/harbor-operator that referenced this issue Jan 28, 2021
@sguyennet
fix(harbor class) Close goharbor#399
feabfd7 
Signed-off-by: Simon Guyennet <simon.guyennet@corp.ovh.com>
sguyennet added a commit to sguyennet/harbor-operator that referenced this issue Jan 28, 2021
@sguyennet
fix(harbor class) Close goharbor#399
a3b5eeb 
Signed-off-by: Simon Guyennet <simon.guyennet@corp.ovh.com>
sguyennet added a commit to sguyennet/harbor-operator that referenced this issue Jan 28, 2021
@sguyennet
fix(harbor class) Close goharbor#399
03314bf 
Signed-off-by: Simon Guyennet <simon.guyennet@corp.ovh.com>
sguyennet added a commit to sguyennet/harbor-operator that referenced this issue Jan 28, 2021
@sguyennet
fix(harbor class) Close goharbor#399
88ee9e0 
Signed-off-by: Simon Guyennet <simon.guyennet@corp.ovh.com>
steven-zou added a commit that referenced this issue Jan 30, 2021
@steven-zou
Merge pull request #425 from sguyennet/dev/harbor-class
481242c 
fix(harbor class) Close #399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sguyennet sguyennet

@holyhope holyhope

Labels
kind/bug Something isn't working release/1.0 Issues for the release 1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sguyennet @holyhope @steven-zou