Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgresql not deleted with harborcluster #1064

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ShouEnHsiao
Copy link
Contributor

This CL is from #1014 which adds ownerReference to expectCR in PostgreSQLController.Update before comparing. Origin expectCR have no OwnerReference.

@github-actions github-actions bot requested review from bitsf and chlins August 8, 2023 06:08
@MarcelMue
Copy link
Collaborator

Please make sure you have signed your commit.

This CL is from goharbor#1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: ShouEnHsiao <shouenhsiao@google.com>
Copy link
Collaborator

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @thcdrt can you also review?

@thcdrt thcdrt merged commit 4989936 into goharbor:main Aug 21, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants