Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pg) add postgress kb annotation and comments #559

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

Ghostbaby
Copy link
Contributor

add postgress kb annotation and comments

fixed #552

Signed-off-by: zhuhuijun zhuhuijunzhj@gmail.com

@bitsf
Copy link
Collaborator

bitsf commented Apr 19, 2021

should regenerate files if update types

Copy link
Collaborator

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do changes.

apis/goharbor.io/v1alpha3/harborcluster_types.go Outdated Show resolved Hide resolved
apis/goharbor.io/v1alpha3/harborcluster_types.go Outdated Show resolved Hide resolved
apis/goharbor.io/v1alpha3/harborcluster_types.go Outdated Show resolved Hide resolved
apis/goharbor.io/v1alpha3/harborcluster_types.go Outdated Show resolved Hide resolved
add postgress kb annotation and comments

fixed goharbor#552

Signed-off-by: zhuhuijun <zhuhuijunzhj@gmail.com>
Copy link
Collaborator

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ghostbaby Ghostbaby merged commit 9606f48 into goharbor:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should apply kb annotation and comments to the PostgresSQLSpec
4 participants