Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add redis spec kb comments anno and comments and remove useless … #560

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

chlins
Copy link
Member

@chlins chlins commented Apr 19, 2021

Fix issue: #553

Changes

  1. remove useless fields in redis spec.
  2. add kubebuilder marker and comments for redis spec fields.

Signed-off-by: chlins chlins.zhang@gmail.com

…fields

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the fix/add-redis-kb-anno-comments branch from cb20b7e to d30710c Compare April 19, 2021 02:27
Copy link
Collaborator

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heww heww merged commit 7f03b59 into goharbor:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants