Make PostgreSQL secrets name template configurable #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajudge
changed the title
dajudge
changed the title
dajudge
commented
Apr 21, 2021
Comment on lines
168
to
178
| type SecretsTemplate string | ||
|
|
||
| func (f *SecretsTemplate) Format(a ...string) string { | ||
| res := string(*f) | ||
|
|
||
| for i := 0; i < len(a); i += 2 { | ||
| res = strings.Replace(res, "{"+a[i]+"}", a[i+1], -1) | ||
| } | ||
|
|
||
| return res | ||
| } |
There was a problem hiding this comment.
@steven-zou this is a blunt copy from https://github.com/zalando/postgres-operator/blob/0745ce7cce63ab6431103d27eb08e54ec47d2b15/pkg/util/config/util.go#L232
does this need to be re-written to avoid licensing issues?
There was a problem hiding this comment.
@Ghostbaby maybe you could say sth about this?
Fixes #572 Signed-off-by: Alex Stockinger <mail@alexstockinger.de>
Signed-off-by: Alex Stockinger <mail@alexstockinger.de>
|
@steven-zou @Ghostbaby @bitsf plz have a look at the comment above regarding the piece of code from the postgres-operator project before merging the PR |
bitsf
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572
Signed-off-by: Alex Stockinger mail@alexstockinger.de