Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config):handle empty redis password #625

Merged
merged 1 commit into from Apr 29, 2021

Conversation

steven-zou
Copy link
Collaborator

  • handle empty redis password for js
  • handle empty redis password for registry
  • handle empty redis password for chartmuseum

Signed-off-by: Steven Zou szou@vmware.com

also fix #608

- handle empty redis password for js
- handle empty redis password for registry
- handle empty redis password for chartmuseum

Signed-off-by: Steven Zou <szou@vmware.com>

also fix goharbor#608
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-zou steven-zou merged commit 0592321 into goharbor:master Apr 29, 2021
@steven-zou steven-zou deleted the fix/empty_redis_pass_issue branch April 29, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Harbor with external redis without password failed
3 participants