Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add ingress class #800

Merged
merged 3 commits into from Nov 5, 2021
Merged

Feature/add ingress class #800

merged 3 commits into from Nov 5, 2021

Conversation

wangcanfengxs
Copy link
Collaborator

No description provided.

@wangcanfengxs wangcanfengxs linked an issue Nov 2, 2021 that may be closed by this pull request
test / upgrade ingress-nginx 1.0.x #776
Closed
yxxhero
yxxhero approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

soulseen
soulseen approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@soulseen soulseen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgth

@soulseen soulseen merged commit 3553e9c into goharbor:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsf bitsf bitsf approved these changes

@yxxhero yxxhero yxxhero approved these changes

@soulseen soulseen soulseen approved these changes

@steven-zou steven-zou Awaiting requested review from steven-zou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test / upgrade ingress-nginx 1.0.x
4 participants
@wangcanfengxs @bitsf @yxxhero @soulseen