Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme of day2 #831

Merged
merged 1 commit into from Jan 4, 2022
Merged

Fix readme of day2 #831

merged 1 commit into from Jan 4, 2022

Conversation

lubronzhan
Copy link
Collaborator

Fix readme of day2
ServerURL must begin with http or https
Change rule format
Add unit test

Fix #827

@lubronzhan lubronzhan force-pushed the fix_day2 branch 2 times, most recently from 6ef9a23 to f22839b Compare December 22, 2021 23:30
ServerURL must begin with http or https

Signed-off-by: lubronzhan <lzhan@vmware.com>
insecure: true
rules: ## rules to define to rewrite image path
- "docker.io,testharbor" ## <repo-regex>,<harbor-project>

- "docker.io=>testharbor" ## <repo-regex>,<harbor-project>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix it in another doc MR.

Copy link
Collaborator

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it now

@steven-zou steven-zou merged commit e4f467a into goharbor:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The HarborServerConfiguration of DAY2 can not reach health status
2 participants