Merge pull request #5781 from cd1989/insufficient-scope-problem

Add pull scope to post/put/patch method
goharbor · Sep 3, 2018 · c4fc79e · c4fc79e
2 parents 179d7be + 6eb972c
commit c4fc79e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/common/utils/registry/auth/tokenauthorizer.go b/src/common/utils/registry/auth/tokenauthorizer.go
@@ -164,7 +164,7 @@ func parseScopes(req *http.Request) ([]*token.ResourceActions, error) {
 		case http.MethodGet, http.MethodHead:
 			scope.Actions = []string{"pull"}
 		case http.MethodPost, http.MethodPut, http.MethodPatch:
-			scope.Actions = []string{"push"}
+			scope.Actions = []string{"pull", "push"}
 		case http.MethodDelete:
 			scope.Actions = []string{"*"}
 		default:

diff --git a/src/common/utils/registry/auth/tokenauthorizer_test.go b/src/common/utils/registry/auth/tokenauthorizer_test.go
@@ -116,10 +116,9 @@ func TestParseScopes(t *testing.T) {
 	assert.Nil(t, err)
 	assert.Equal(t, 1, len(scopses))
 	assert.EqualValues(t, &token.ResourceActions{
-		Type: "repository",
-		Name: "library/mysql/5.6",
-		Actions: []string{
-			"push"},
+		Type:    "repository",
+		Name:    "library/mysql/5.6",
+		Actions: []string{"pull", "push"},
 	}, scopses[0])
 
 	// invalid