Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "admin group" in OIDC mode #13113

Closed
reasonerjt opened this issue Sep 21, 2020 · 1 comment
Closed

Support "admin group" in OIDC mode #13113

reasonerjt opened this issue Sep 21, 2020 · 1 comment
Assignees
@reasonerjt @AllForNothing
Labels
area/oidc target/2.2.0

Comments

@reasonerjt
Copy link
Contributor

reasonerjt commented Sep 21, 2020 •
edited
Loading

Goal:

  1. Add an attribute "Admin group" to OIDC configuration. This field will be enabled only when the admin set the "Group
    Claim" .
  2. When the user login via OIDC provider if the value of admin group is in the list of group entries under this claim, the user will have the permission of system admin. The change in membership or "admin group" setting will only be reflected if his ID token is refreshed in Harbor such as re-login.
    Non-goal:
  3. There are inconsistency issues on UI, as described in LDAP Administrators Not Marked in Users Menu #8052
  4. The admin group setting will remain in auth setting, and will not be moved to the Groups view.
@reasonerjt reasonerjt changed the title Support admin group in Support "admin group" in OIDC mode Sep 21, 2020
@reasonerjt reasonerjt mentioned this issue Sep 21, 2020
Closed
@AllForNothing AllForNothing mentioned this issue Oct 20, 2020
Merged
@reasonerjt
Copy link
Contributor Author

Fixed in #13312 and #13313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reasonerjt reasonerjt

@AllForNothing AllForNothing

Labels
area/oidc target/2.2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reasonerjt @AllForNothing