Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize the text of the OIDC login button #13198

Closed
thoro opened this issue Sep 30, 2020 · 8 comments · Fixed by #19575
Closed

Customize the text of the OIDC login button #13198

thoro opened this issue Sep 30, 2020 · 8 comments · Fixed by #19575
Assignees
@stonezdj @AllForNothing
Labels
area/API area/oidc target/2.10.0

Comments

@thoro
Copy link
Contributor

thoro commented Sep 30, 2020

Is your feature request related to a problem? Please describe.
Users might be confused if they are presented with an OIDC login button and are used to "Company SSO", most software supports to customize the text of the login links.

For example:

"Login with Dex"
"Login with Okta"
"Login with SSO"

etc.

Describe the solution you'd like
The OIDC provider should have a field to define the text presented on the UI.
@reasonerjt reasonerjt self-assigned this Sep 30, 2020
@reasonerjt
Copy link
Contributor

Since we have the name of OIDC provider we may render the button dynamically?
cc @xaleeks @AllForNothing

@thoro
Copy link
Contributor Author

thoro commented Sep 30, 2020

Even though my samples all give the prefix "Login with", I would let the whole text to be decided, without a static portion!

@steven-zou steven-zou added the kind/requirement New feature or idea on top of harbor label Oct 12, 2020
@xaleeks
Copy link
Contributor

xaleeks commented Oct 25, 2020

I'm ok with this.

@AllForNothing
Copy link
Contributor

@reasonerjt As discussed, the provider name will be provided in the response of "systeminfo" API

@reasonerjt reasonerjt removed their assignment May 17, 2021
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Jul 6, 2022
@stonezdj stonezdj removed the Stale label Jul 7, 2022
@AllForNothing AllForNothing assigned stonezdj and unassigned xaleeks Oct 17, 2022
@AllForNothing AllForNothing mentioned this issue Dec 8, 2022
Closed
@wy65701436 wy65701436 added target/2.9.0 and removed candidate/2.9.0 UX backlog kind/requirement New feature or idea on top of harbor labels Apr 10, 2023
@github-actions
Copy link

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Jun 12, 2023
@rgarcia89
Copy link
Contributor

Any update here?

@VladoPortos
Copy link

Would be nice to have.

stonezdj pushed a commit to stonezdj/harbor that referenced this issue Nov 14, 2023
Add oidc provider name to systeminfo API
221a8ae 
   fixes goharbor#13198

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj mentioned this issue Nov 14, 2023
Merged
5 tasks
stonezdj pushed a commit to stonezdj/harbor that referenced this issue Nov 14, 2023
@stonezdj
Add oidc provider name to systeminfo API
c88c97d 
   fixes goharbor#13198

Signed-off-by: stonezdj <daojunz@vmware.com>
stonezdj added a commit that referenced this issue Nov 15, 2023
@stonezdj
Add oidc provider name to systeminfo API (#19575)
3f6c029 
fixes #13198

Signed-off-by: stonezdj <daojunz@vmware.com>
AllForNothing pushed a commit to AllForNothing/harbor that referenced this issue Nov 15, 2023
Show OIDC provider name on the OIDC login button
903fd48 
1. Related issue goharbor#13198

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing mentioned this issue Nov 15, 2023
Merged
5 tasks
AllForNothing added a commit that referenced this issue Nov 15, 2023
@AllForNothing
Show OIDC provider name on the OIDC login button (#19581)
6a6e295 
1. Related issue #13198

Signed-off-by: AllForNothing <sshijun@vmware.com>
altynbaev pushed a commit to altynbaev/harbor that referenced this issue Jan 29, 2024
@stonezdj
Add oidc provider name to systeminfo API (goharbor#19575)
158000b 
fixes goharbor#13198

Signed-off-by: stonezdj <daojunz@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
altynbaev pushed a commit to altynbaev/harbor that referenced this issue Jan 29, 2024
@AllForNothing
Show OIDC provider name on the OIDC login button (goharbor#19581)
c83f553 
1. Related issue goharbor#13198

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonezdj stonezdj

@AllForNothing AllForNothing

Labels
area/API area/oidc target/2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add oidc provider name to systeminfo API stonezdj/harbor
9 participants
@thoro @reasonerjt @stonezdj @wy65701436 @rgarcia89 @steven-zou @VladoPortos @AllForNothing @xaleeks