Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label color issue #14387

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

AllForNothing
Copy link
Contributor

Fixes #14377

light:
image

dark:
image

Signed-off-by: AllForNothing sshijun@vmware.com

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #14387 (e3958d2) into master (4c47b17) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14387   +/-   ##
=======================================
  Coverage   64.06%   64.06%           
=======================================
  Files         915      915           
  Lines       63486    63486           
  Branches     2034     2034           
=======================================
+ Hits        40674    40675    +1     
+ Misses      18876    18873    -3     
- Partials     3936     3938    +2     
Flag Coverage Δ
unittests 64.06% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/orm/orm.go 67.64% <0.00%> (-4.42%) ⬇️
src/controller/event/topic.go 9.00% <0.00%> (-1.81%) ⬇️
src/jobservice/period/enqueuer.go 63.93% <0.00%> (-0.82%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 52.99% <0.00%> (+5.98%) ⬆️

Copy link
Contributor

@jwangyangls jwangyangls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should check the reason for this problem (whether there was a modification error). I checked the version V2.2.0 that I installed before. This problem did not appear, but why did the new version appear?

@AllForNothing AllForNothing merged commit f0dd9e5 into goharbor:master Mar 8, 2021
@AllForNothing AllForNothing deleted the label-color branch April 14, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The color selection in Label creation is unreadable in light mode
3 participants