Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collection untaged and is cosign signed artifact fail #16418

Closed
YangJiao0817 opened this issue Feb 25, 2022 · 0 comments · Fixed by #16462
Closed

Garbage collection untaged and is cosign signed artifact fail #16418

YangJiao0817 opened this issue Feb 25, 2022 · 0 comments · Fixed by #16462
Assignees
@wy65701436
Labels
area/cosign area/gc kind/bug target/2.5.0
Milestone
Sprint 132

Comments

@YangJiao0817
Copy link
Member

Expected behavior and actual behavior:
Expected:Garbage collection of untaged and cosigned artifacts should not fail, and artifact and signature should be collected together
Actual:Garbage collection untaged and is cosign signed artifact fail

Steps to reproduce the problem:

  1. push untaged artifact to harbor
  2. Use cosign sign artifact

图片

3. Check Allow garbage collection on untagged artifacts and trigger GC

图片

图片

Versions:

  • harbor version: v2.5.0-abd85284

Additional context:
GC error log

2022-02-25T07:11:05Z [INFO] [/jobservice/job/impl/gc/garbage_collection.go:145]: Garbage Collection parameters: [delete_untagged: true, dry_run: false, time_window: 2]
2022-02-25T07:11:05Z [INFO] [/jobservice/job/impl/gc/garbage_collection.go:155]: start to run gc in job.
2022-02-25T07:11:05Z [INFO] [/jobservice/job/impl/gc/garbage_collection.go:418]: start to delete untagged artifact (no actually deletion for dry-run mode)
stonezdj added a commit to stonezdj/harbor that referenced this issue Mar 3, 2022
@stonezdj
The DB config manager is not init on jobservice to call config.WithNo…
2060be1 
…tary

  Make func defaultMgr() public
  Set DefaultCfgManager to RestCfgManager and Load it in the jobservice main
  config.WithNotary call DefaultMgr(), it wil get the RestCfgManager
  Fixes goharbor#16418

Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj stonezdj mentioned this issue Mar 3, 2022
Merged
stonezdj added a commit to stonezdj/harbor that referenced this issue Mar 3, 2022
@stonezdj
The DB config manager is not init on jobservice to call config.WithNo…
5618f6d 
…tary

  Make func defaultMgr() public
  Set DefaultCfgManager to RestCfgManager and Load it in the jobservice main
  config.WithNotary call DefaultMgr(), it wil get the RestCfgManager
  Fixes goharbor#16418

Signed-off-by: stonezdj <stonezdj@gmail.com>
@yanji09 yanji09 added this to the Sprint 132 milestone Mar 7, 2022
@marvinpeter-kisters marvinpeter-kisters mentioned this issue Dec 20, 2022
Open
@YangJiao0817 YangJiao0817 mentioned this issue Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wy65701436 wy65701436

Labels
area/cosign area/gc kind/bug target/2.5.0
Projects
None yet
Milestone
Sprint 132
Development

Successfully merging a pull request may close this issue.

The DB config manager is not init on jobservice call config.WithNotary stonezdj/harbor
3 participants
@wy65701436 @yanji09 @YangJiao0817