Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CVE data is inaccurate #17184

Closed
YangJiao0817 opened this issue Jul 18, 2022 · 5 comments · Fixed by #17232
Closed

Export CVE data is inaccurate #17184

YangJiao0817 opened this issue Jul 18, 2022 · 5 comments · Fixed by #17232
Assignees

Comments

@YangJiao0817
Copy link
Member

YangJiao0817 commented Jul 18, 2022

Expected behavior and actual behavior:
Expected:The exported CVE data is consistent with the UI page
Actual:The exported CVE data is inconsistent with the UI page.Package column displayed incorrectly.Missing CVE data

Steps to reproduce the problem:

  1. Create a project as test02
  2. Push images to this project
    docker push domain/test02/goharbor/harbor-portal:v2.5.3
    docker push domain/test02/goharbor/notary-server-photon:v2.5.3
  3. Scan
  4. Export CVE And download

图片

  1. Compare CVE data
    UI page Projects<test02<goharbor/notary-server-photon

图片

图片

Package column is not consistent with UI page, there are curl and curl-libs in UI page, only curl-libs in CSV file.
UI page has 8 records in curl + curl-libs and 7 records in CSV file.

Versions:

  • harbor version: v2.6.0-f3edb03b
@AllForNothing
Copy link
Contributor

@prahaladdarkin Please have a look at this

@prahaladdarkin
Copy link
Contributor

@YangJiao0817 I tried to reproduce the above issue with the following images:
mongo:latest , ubuntu:latest, goharbor/prepare:v2.5.3. In all cases my count matched.

Could this be an issue with the goharbor/notary-server-photon?

cc @wy65701436 @AllForNothing

@YangJiao0817
Copy link
Member Author

@prahaladdarkin
goharbor/harbor-portal:v2.5.3:
图片

goharbor/notary-server-photon:v2.5.3:
图片

goharbor/harbor-portal:v2.5.3 and goharbor/notary-server-photon:v2.5.3 have some of the same CVEs, maybe this is the reason

@prahaladdarkin
Copy link
Contributor

@YangJiao0817 referring to the attached CSV file image for image harbor-portal - the CVE data matches the UI.

Screen Shot 2022-07-25 at 12 36 16 AM

For the notary-server-photon image though there is one row less. This is due to presence of a particular CVE (in this case CVE-2022-27191) present in two version of the same Go package as shown in below screenshot (the package versions are highlighted).

Screen Shot 2022-07-25 at 12 42 01 AM

As a part of the fix for issue #17188, package versions are now being included within the CSV report and this inclusion should help resolve the observation mentioned in the current issue

prahaladdarkin added a commit to prahaladdarkin/harbor that referenced this issue Jul 24, 2022
Closes:
* CVE Data Export API IDOR issue
* goharbor#17199
* goharbor#17193
* goharbor#17188
* goharbor#17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
AllForNothing pushed a commit to AllForNothing/harbor that referenced this issue Jul 25, 2022
Closes:
* CVE Data Export API IDOR issue
* goharbor#17199
* goharbor#17193
* goharbor#17188
* goharbor#17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
prahaladdarkin added a commit to prahaladdarkin/harbor that referenced this issue Jul 25, 2022
Closes:
* CVE Data Export API IDOR issue
* goharbor#17199
* goharbor#17193
* goharbor#17188
* goharbor#17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
@prahaladdarkin
Copy link
Contributor

Fixed within #17232 (under review).

prahaladdarkin added a commit to prahaladdarkin/harbor that referenced this issue Jul 26, 2022
Closes:
* CVE Data Export API IDOR issue
* goharbor#17199
* goharbor#17193
* goharbor#17188
* goharbor#17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
prahaladdarkin added a commit to prahaladdarkin/harbor that referenced this issue Jul 26, 2022
Closes:
* CVE Data Export API IDOR issue
* goharbor#17199
* goharbor#17193
* goharbor#17188
* goharbor#17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
wy65701436 pushed a commit that referenced this issue Jul 26, 2022
Closes:
* CVE Data Export API IDOR issue
* #17199
* #17193
* #17188
* #17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
sluetze pushed a commit to sluetze/harbor that referenced this issue Oct 29, 2022
…rbor#17232)

Closes:
* CVE Data Export API IDOR issue
* goharbor#17199
* goharbor#17193
* goharbor#17188
* goharbor#17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
mcsage pushed a commit to mcsage/harbor that referenced this issue Feb 16, 2023
…rbor#17232)

Closes:
* CVE Data Export API IDOR issue
* goharbor#17199
* goharbor#17193
* goharbor#17188
* goharbor#17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants