Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scanner] Vul policy check still work on trivvy #9780

Closed
wy65701436 opened this issue Nov 7, 2019 · 2 comments · Fixed by #9802
Closed

[Scanner] Vul policy check still work on trivvy #9780

wy65701436 opened this issue Nov 7, 2019 · 2 comments · Fixed by #9802
Assignees
@wy65701436 @heww
Labels
area/API area/interrogation-service priority/high target/1.10.0

Comments

@wy65701436
Copy link
Contributor

  1. enable vul policy check with Critical
  2. set trivvy to default
  3. scan a image
@wy65701436 wy65701436 changed the title [Scanner] Vul policy check still work on trivvy scan image [Scanner] Vul policy check still work on trivvy Nov 7, 2019
@steven-zou
Copy link
Contributor

Maybe a bug from aquasecurity/harbor-scanner-trivy#50

@steven-zou
Copy link
Contributor

We'll do change at harbor side.

wy65701436 added a commit to wy65701436/harbor that referenced this issue Nov 8, 2019
@wy65701436
Disable policy check when pull without bearer token
415bdfa 
This commit is to fix goharbor#9780.
To align with OCI spec, when a docker pull request without bearer token in header comes in, Harbor should not intecepte it(return a 412 if check fail)
when the policy check is enabled. As the 401 is expected by the docker/caller, and then to ask token service which url is in the 401 header.

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 mentioned this issue Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wy65701436 wy65701436

@heww heww

Labels
area/API area/interrogation-service priority/high target/1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable policy check when pull without bearer token wy65701436/harbor
3 participants
@wy65701436 @heww @steven-zou