Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add whitelisting in idtoken for ping endpoint #13286

Closed
wants to merge 2 commits into from
Closed

add whitelisting in idtoken for ping endpoint #13286

wants to merge 2 commits into from

Conversation

sharkymcdongles
Copy link

Solves log spam in this issue:

#12261

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #13286 into master will decrease coverage by 11.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13286       +/-   ##
===========================================
- Coverage   61.94%   50.65%   -11.29%     
===========================================
  Files         915      276      -639     
  Lines       54103    13372    -40731     
  Branches     2020     2023        +3     
===========================================
- Hits        33513     6774    -26739     
+ Misses      16832     5907    -10925     
+ Partials     3758      691     -3067     
Flag Coverage Δ
#unittests 50.65% <ø> (-11.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rtal/src/lib/components/filter/filter.component.ts 80.76% <0.00%> (-3.85%) ⬇️
...list-repository-ro/list-repository-ro.component.ts 60.00% <0.00%> (-1.54%) ⬇️
...t/artifact-list-tab/artifact-list-tab.component.ts 30.62% <0.00%> (-0.11%) ⬇️
src/jobservice/logger/factory.go
src/server/middleware/blob/copy_artifact.go
src/core/promgr/metamgr/metamgr.go
src/jobservice/worker/cworker/reaper.go
src/registryctl/handlers/router.go
src/jobservice/api/server.go
src/controller/quota/util.go
... and 632 more

make specific
@heww
Copy link
Contributor

heww commented Nov 9, 2020

Hi @sharkymcdongles Can you look at this PR #13422 which will skip security middleware for ping endpoint?

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jun 11, 2021
@stale stale bot closed this Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants