Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce warning logs in OIDC middleware #14116

Merged
merged 1 commit into from Feb 1, 2021

Conversation

reasonerjt
Copy link
Contributor

If the request does not have bearer token in the header, do not decode
the empty string.
Fixes #12261

Signed-off-by: Daniel Jiang jiangd@vmware.com

If the request does not have bearer token in the header, do not decode
the empty string.
Fixes goharbor#12261

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@reasonerjt reasonerjt added target/2.2.0 target/RC tracking issue which are must fixed before RC milestone labels Jan 28, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #14116 (2dd499b) into master (9574f8c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14116      +/-   ##
==========================================
- Coverage   63.82%   63.78%   -0.04%     
==========================================
  Files         954      954              
  Lines       63866    63871       +5     
  Branches     2169     2170       +1     
==========================================
- Hits        40760    40743      -17     
- Misses      19121    19137      +16     
- Partials     3985     3991       +6     
Flag Coverage Δ
unittests 63.78% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/middleware/security/idtoken.go 22.58% <100.00%> (-8.46%) ⬇️
src/common/utils/oidc/helper.go 46.50% <0.00%> (-4.50%) ⬇️
...ig/vulnerability/vulnerability-config.component.ts 58.33% <0.00%> (-3.48%) ⬇️
src/controller/event/topic.go 9.00% <0.00%> (-1.81%) ⬇️
src/chartserver/utils.go 73.21% <0.00%> (-1.46%) ⬇️
...lnerability-scanning/result-bar-chart.component.ts 51.11% <0.00%> (-0.06%) ⬇️
src/pkg/exporter/system_collector.go 0.00% <0.00%> (ø)
...ry/artifact/artifact-tag/artifact-tag.component.ts 40.22% <0.00%> (+0.68%) ⬆️
src/pkg/exporter/project_collector.go 30.98% <0.00%> (+0.98%) ⬆️
... and 1 more

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ywk253100 ywk253100 merged commit 120d88a into goharbor:master Feb 1, 2021
@reasonerjt reasonerjt deleted the reduce-oidc-warning branch September 21, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/RC tracking issue which are must fixed before RC milestone target/2.2.0
Projects
None yet
3 participants