Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grafana example for metrics #14504

Merged
merged 1 commit into from May 14, 2021
Merged

Conversation

ninjadq
Copy link
Member

@ninjadq ninjadq commented Mar 24, 2021

add json file for grafana

Signed-off-by: DQ dengq@vmware.com

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #14504 (06f14ec) into master (b445683) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14504      +/-   ##
==========================================
- Coverage   65.60%   65.57%   -0.03%     
==========================================
  Files         921      925       +4     
  Lines       69224    69462     +238     
  Branches     2037     2101      +64     
==========================================
+ Hits        45413    45550     +137     
- Misses      19888    19962      +74     
- Partials     3923     3950      +27     
Flag Coverage Δ
unittests 65.57% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...av/replication/total-replication-page.component.ts 37.93% <0.00%> (-25.71%) ⬇️
...portal/src/app/services/skinable-config.service.ts 54.54% <0.00%> (-25.46%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
...rc/app/base/harbor-shell/harbor-shell.component.ts 62.16% <0.00%> (-3.97%) ⬇️
src/portal/src/app/app.component.ts 76.74% <0.00%> (-2.75%) ⬇️
src/pkg/exporter/project_collector.go 28.98% <0.00%> (-2.01%) ⬇️
...shared/components/navigator/navigator.component.ts 39.21% <0.00%> (-1.61%) ⬇️
...se/project/p2p-provider/policy/policy.component.ts 47.08% <0.00%> (-0.20%) ⬇️
src/pkg/exporter/cache.go 0.00% <0.00%> (ø)
src/pkg/exporter/collector.go 80.00% <0.00%> (ø)
... and 22 more

@ninjadq ninjadq force-pushed the add_exporter_example branch 2 times, most recently from 6a4bfd1 to bb534b8 Compare March 31, 2021 02:38
add json file for grafana

Signed-off-by: DQ <dengq@vmware.com>
@a-mccarthy
Copy link

@ninjadq Is this dashboard meant to be an example that users can use to get started using metrics with Harbor? If so, it might also be useful to add a link to this example from the metrics docs once this is merged.

Is this something that will be maintained/tested?

@ninjadq
Copy link
Member Author

ninjadq commented May 11, 2021

hi @a-mccarthy, yes it is the example for user to get started with. I think it can be added to doc also. Thanks for mention this

@a-mccarthy a-mccarthy added the doc-impact Engineering issues that will require a change in user docs label May 11, 2021
@heww heww merged commit a19f6f8 into goharbor:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-impact Engineering issues that will require a change in user docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants