Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui issue for add p2p policy component #15533

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

AllForNothing
Copy link
Contributor

Fixes #15510
Signed-off-by: AllForNothing sshijun@vmware.com

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #15533 (a3883e4) into master (06f2414) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15533      +/-   ##
==========================================
+ Coverage   67.00%   67.02%   +0.01%     
==========================================
  Files         925      925              
  Lines       76679    76681       +2     
  Branches     2260     2260              
==========================================
+ Hits        51381    51396      +15     
+ Misses      21358    21341      -17     
- Partials     3940     3944       +4     
Flag Coverage Δ
unittests 67.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rovider/add-p2p-policy/add-p2p-policy.component.ts 39.50% <100.00%> (+0.37%) ⬆️
...se/project/p2p-provider/policy/policy.component.ts 45.62% <100.00%> (+0.19%) ⬆️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 32.15% <0.00%> (+3.52%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 52.99% <0.00%> (+5.98%) ⬆️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 75.00% <0.00%> (+12.50%) ⬆️

Copy link
Member

@ninjadq ninjadq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ninjadq ninjadq merged commit a854500 into goharbor:master Sep 3, 2021
@AllForNothing AllForNothing deleted the p2p-edit branch September 23, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The P2P preheat edit page cannot be modified
3 participants