Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update push and pull command for helm #16552

Merged
merged 1 commit into from Mar 18, 2022
Merged

Conversation

AllForNothing
Copy link
Contributor

Fixes #16537
Signed-off-by: AllForNothing sshijun@vmware.com

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #16552 (b34df2f) into main (c54f51d) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16552      +/-   ##
==========================================
- Coverage   67.39%   67.37%   -0.02%     
==========================================
  Files         951      951              
  Lines       78924    78938      +14     
  Branches     2322     2331       +9     
==========================================
- Hits        53190    53185       -5     
- Misses      22171    22190      +19     
  Partials     3563     3563              
Flag Coverage Δ
unittests 67.37% <37.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ry/artifact/artifact-tag/artifact-tag.component.ts 32.23% <0.00%> (+0.41%) ⬆️
...t/artifact-list-tab/artifact-list-tab.component.ts 26.77% <33.33%> (-0.22%) ⬇️
...c/app/base/project/repository/artifact/artifact.ts 51.85% <38.09%> (-48.15%) ⬇️
...ared/components/push-image/push-image.component.ts 36.36% <100.00%> (ø)
...-nav/gc-page/gc/gc-history/gc-history.component.ts 50.94% <0.00%> (-9.44%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.43% <0.00%> (-5.22%) ⬇️
src/pkg/scan/dao/scanner/model.go 53.06% <0.00%> (-5.13%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 57.14% <0.00%> (-4.77%) ⬇️
src/pkg/p2p/preheat/provider/kraken.go 78.57% <0.00%> (-2.57%) ⬇️
src/pkg/p2p/preheat/provider/dragonfly.go 68.25% <0.00%> (-1.75%) ⬇️
... and 3 more

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit c898a41 into goharbor:main Mar 18, 2022
@AllForNothing AllForNothing deleted the helm branch March 25, 2022 03:57
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The push command for the helm chart is out of date
3 participants