Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]fix close response missing #16822

Merged
merged 1 commit into from May 9, 2022

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 7, 2022

It has to close the http response on deleting manifest

Signed-off-by: Wang Yan wangyan@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

It has to close the http response on deleting manifest

Signed-off-by: Wang Yan <wangyan@vmware.com>
@wy65701436 wy65701436 changed the title fix close response missing [cherry-pick]fix close response missing May 7, 2022
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #16822 (c4dafc8) into release-2.5.0 (55f7645) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.5.0   #16822      +/-   ##
=================================================
- Coverage          67.42%   67.42%   -0.01%     
=================================================
  Files                949      949              
  Lines              78861    78862       +1     
  Branches            2331     2331              
=================================================
- Hits               53173    53172       -1     
- Misses             22129    22130       +1     
- Partials            3559     3560       +1     
Flag Coverage Δ
unittests 67.42% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/reg/adapter/dockerhub/adapter.go 33.20% <0.00%> (-0.14%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 57.14% <0.00%> (-4.77%) ⬇️
src/jobservice/worker/cworker/c_worker.go 68.42% <0.00%> (+1.91%) ⬆️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️

@wy65701436 wy65701436 merged commit 4afd4ae into goharbor:release-2.5.0 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants