Introduce system artifact manager cleanup job #16879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16879 +/- ##
==========================================
+ Coverage 67.15% 67.17% +0.01%
==========================================
Files 974 977 +3
Lines 81555 81644 +89
Branches 2599 2599
==========================================
+ Hits 54767 54841 +74
- Misses 23057 23068 +11
- Partials 3731 3735 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
reviewed
May 23, 2022
wy65701436
reviewed
May 30, 2022
|
|
||
| func init() { | ||
| if err := scheduler.RegisterCallbackFunc(SystemArtifactCleanupCallback, cleanupCallBack); err != nil { | ||
| log.Fatalf("failed to register the callback for the scan all schedule, error %v", err) |
There was a problem hiding this comment.
it's for the system artifact?
wy65701436
reviewed
May 30, 2022
wy65701436
reviewed
May 30, 2022
| } | ||
|
|
||
| func scheduleSystemArtifactCleanJob(ctx context.Context) { | ||
| cronSpec := "0 0 0 * * *" |
There was a problem hiding this comment.
please add a comment for this, thanks.
wy65701436
reviewed
May 30, 2022
wy65701436
reviewed
May 30, 2022
| } | ||
|
|
||
| func (c *Cleanup) ShouldRetry() bool { | ||
| return true |
There was a problem hiding this comment.
refer to this #16833 (comment)
wy65701436
reviewed
May 30, 2022
wy65701436
reviewed
May 30, 2022
wy65701436
reviewed
May 30, 2022
wy65701436
reviewed
May 30, 2022
wy65701436
reviewed
May 30, 2022
chlins
reviewed
May 31, 2022
chlins
reviewed
May 31, 2022
prahaladdarkin
force-pushed
the
pd_sysartifact_job
branch
2 times, most recently
from
25bfbdd
to
e217d79
Compare
wy65701436
reviewed
Jun 2, 2022
| @@ -0,0 +1,128 @@ | |||
| package systemartifact | |||
There was a problem hiding this comment.
the UT should cover all the methods, we need more, thanks.
wy65701436
reviewed
Jun 2, 2022
| @@ -0,0 +1,36 @@ | |||
| package systemartifact | |||
prahaladdarkin
force-pushed
the
pd_sysartifact_job
branch
3 times, most recently
from
e3b6eef
to
a3d98da
Compare
Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
prahaladdarkin
force-pushed
the
pd_sysartifact_job
branch
from
a3d98da
to
55b209e
Compare
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of change:
Closes #16878
Signed-off-by: prahaladdarkin prahaladd@vmware.com