Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the update of retention policy #17064

Merged
merged 1 commit into from Jun 23, 2022

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 23, 2022

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins requested a review from a team as a code owner June 23, 2022 08:38
@chlins chlins added the release-note/update Update or Fix label Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #17064 (b11970a) into main (b11970a) will not change coverage.
The diff coverage is n/a.

❗ Current head b11970a differs from pull request most recent head b3fda83. Consider uploading reports for the commit b3fda83 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17064   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files         978      978           
  Lines       82057    82057           
  Branches     2614     2614           
=======================================
  Hits        55035    55035           
  Misses      23251    23251           
  Partials     3771     3771           
Flag Coverage Δ
unittests 67.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 8e99c83 into goharbor:main Jun 23, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: chlins <chenyuzh@vmware.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Signed-off-by: chlins <chenyuzh@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants