Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email configuration #17712

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Oct 28, 2022

Email related settings are deprecated
Remove email ping API
Fixes #17683

Signed-off-by: stonezdj stonezdj@gmail.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner October 28, 2022 06:57
@stonezdj stonezdj added the release-note/deprecation Harbor Deprecation MUST need to be in release notes label Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #17712 (7fa7247) into main (0acfbdc) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17712      +/-   ##
==========================================
- Coverage   66.60%   66.57%   -0.04%     
==========================================
  Files         995      994       -1     
  Lines      105898   105673     -225     
  Branches     2602     2602              
==========================================
- Hits        70536    70347     -189     
+ Misses      31464    31425      -39     
- Partials     3898     3901       +3     
Flag Coverage Δ
unittests 66.57% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/config/models/model.go 100.00% <ø> (ø)
src/lib/config/userconfig.go 68.27% <ø> (-1.29%) ⬇️
...g-retention-tasks/tag-retention-tasks.component.ts 61.11% <0.00%> (-25.00%) ⬇️
src/common/rbac/system/namespace.go 35.29% <0.00%> (-11.77%) ⬇️
src/core/auth/authenticator.go 48.81% <0.00%> (-9.45%) ⬇️
src/common/utils/passports.go 86.27% <0.00%> (-3.93%) ⬇️
src/common/utils/email/mail.go 35.05% <0.00%> (-3.10%) ⬇️
src/server/v2.0/restapi/embedded_spec.go 100.00% <0.00%> (ø)
src/portal/src/app/shared/units/shared.utils.ts 36.47% <0.00%> (+2.35%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 62.96% <0.00%> (+4.44%) ⬆️
... and 3 more

   Email related settings are deprecated
   Remove email ping API
   Fixes goharbor#17683

Signed-off-by: stonezdj <stonezdj@gmail.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit a47e175 into goharbor:main Nov 14, 2022
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Nov 14, 2022
Email related settings are deprecated
   Remove email ping API
   Fixes goharbor#17683

Signed-off-by: stonezdj <stonezdj@gmail.com>

Signed-off-by: stonezdj <stonezdj@gmail.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Email related settings are deprecated
   Remove email ping API
   Fixes goharbor#17683

Signed-off-by: stonezdj <stonezdj@gmail.com>

Signed-off-by: stonezdj <stonezdj@gmail.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/deprecation Harbor Deprecation MUST need to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove E-mail config page
4 participants