-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove email configuration #17712
Merged
Merged
Remove email configuration #17712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonezdj
added
the
release-note/deprecation
Harbor Deprecation MUST need to be in release notes
label
Oct 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #17712 +/- ##
==========================================
- Coverage 66.60% 66.57% -0.04%
==========================================
Files 995 994 -1
Lines 105898 105673 -225
Branches 2602 2602
==========================================
- Hits 70536 70347 -189
+ Misses 31464 31425 -39
- Partials 3898 3901 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
force-pushed
the
22oct09_remove_email_ping
branch
from
October 28, 2022 08:04
4d8ff58
to
c77cbe6
Compare
Email related settings are deprecated Remove email ping API Fixes goharbor#17683 Signed-off-by: stonezdj <stonezdj@gmail.com>
stonezdj
force-pushed
the
22oct09_remove_email_ping
branch
from
October 28, 2022 11:36
c77cbe6
to
7fa7247
Compare
zyyw
approved these changes
Nov 1, 2022
chlins
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
Nov 14, 2022
Email related settings are deprecated Remove email ping API Fixes goharbor#17683 Signed-off-by: stonezdj <stonezdj@gmail.com> Signed-off-by: stonezdj <stonezdj@gmail.com>
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
Email related settings are deprecated Remove email ping API Fixes goharbor#17683 Signed-off-by: stonezdj <stonezdj@gmail.com> Signed-off-by: stonezdj <stonezdj@gmail.com> Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email related settings are deprecated
Remove email ping API
Fixes #17683
Signed-off-by: stonezdj stonezdj@gmail.com
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: