Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in CONTRIBUTING.md #17718

Merged
merged 1 commit into from Oct 31, 2022

Conversation

94rain
Copy link
Contributor

@94rain 94rain commented Oct 30, 2022

Comprehensive Summary of your change

Replace two broken links with their alternatives in CONTRIBUTING.md

Issue being fixed

N/A

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "area/doc"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed. (N/A)
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository. (N/A)

@94rain 94rain requested a review from a team as a code owner October 30, 2022 06:44
Signed-off-by: shuyang <21193371+94rain@users.noreply.github.com>

Update CONTRIBUTING.md

Signed-off-by: shuyang <21193371+94rain@users.noreply.github.com>
Copy link
Contributor

@zyyw zyyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #17718 (d903f8c) into main (3050e85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17718   +/-   ##
=======================================
  Coverage   66.63%   66.63%           
=======================================
  Files         995      995           
  Lines      105912   105912           
  Branches     2602     2602           
=======================================
  Hits        70572    70572           
- Misses      31433    31438    +5     
+ Partials     3907     3902    -5     
Flag Coverage Δ
unittests 66.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/auditlog/auditlog.go 14.28% <0.00%> (-42.86%) ⬇️
src/controller/event/topic.go 2.11% <0.00%> (-8.46%) ⬇️
...-job/gc-page/gc/gc-history/gc-history.component.ts 40.69% <0.00%> (-5.82%) ⬇️
src/common/utils/passports.go 90.19% <0.00%> (+3.92%) ⬆️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 36.00% <0.00%> (+4.00%) ⬆️
src/core/api/internal.go 44.82% <0.00%> (+8.62%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 62.96% <0.00%> (+8.88%) ⬆️
...g-retention-tasks/tag-retention-tasks.component.ts 86.11% <0.00%> (+25.00%) ⬆️

@MinerYang MinerYang added the release-note/ignore-for-release Do not include PR or Issue for release notes label Oct 31, 2022
@zyyw zyyw merged commit b91a97d into goharbor:main Oct 31, 2022
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Signed-off-by: shuyang <21193371+94rain@users.noreply.github.com>

Update CONTRIBUTING.md

Signed-off-by: shuyang <21193371+94rain@users.noreply.github.com>

Signed-off-by: shuyang <21193371+94rain@users.noreply.github.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants