Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refine the quay adapter UT #17823

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

chlins
Copy link
Member

@chlins chlins commented Nov 18, 2022

Signed-off-by: chlins chenyuzh@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #17823 (78ac5d2) into release-1.10.0 (245acbe) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #17823      +/-   ##
==================================================
- Coverage           55.99%   55.98%   -0.02%     
==================================================
  Files                 612      612              
  Lines               32467    32467              
  Branches              825      825              
==================================================
- Hits                18181    18177       -4     
- Misses              11487    11491       +4     
  Partials             2799     2799              
Flag Coverage Δ
unittests 55.98% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/replication/registry/healthcheck.go 42.85% <0.00%> (-4.77%) ⬇️
src/common/rbac/casbin.go 85.71% <0.00%> (-4.77%) ⬇️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 86c851b into goharbor:release-1.10.0 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants