Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add harbor arm build parameters #17828

Conversation

Jeremy-boo
Copy link

@Jeremy-boo Jeremy-boo commented Nov 20, 2022

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Add support for multi-arch platform builds

Issue being fixed

Fixes #(issue)

  • Require image for ARM64 architecture  #16959
  • arm64 supported #14330
    Please indicate you've done the following:
  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@Jeremy-boo Jeremy-boo requested a review from a team as a code owner November 20, 2022 08:27
Signed-off-by: Jeremy-boo <bozhu@alauda.io>
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #17828 (1e70697) into release-2.6.0 (498e7e2) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.6.0   #17828      +/-   ##
=================================================
- Coverage          67.19%   67.16%   -0.03%     
=================================================
  Files                993      993              
  Lines              84350    84350              
  Branches            2687     2687              
=================================================
- Hits               56675    56657      -18     
- Misses             23774    23793      +19     
+ Partials            3901     3900       -1     
Flag Coverage Δ
unittests 67.16% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/core/api/internal.go 36.17% <0.00%> (-10.64%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 54.07% <0.00%> (-8.89%) ⬇️
...-job/gc-page/gc/gc-history/gc-history.component.ts 40.22% <0.00%> (-5.75%) ⬇️
src/server/v2.0/handler/user.go 14.02% <0.00%> (+1.79%) ⬆️
src/controller/event/topic.go 10.81% <0.00%> (+1.80%) ⬆️

@wy65701436
Copy link
Contributor

@Jeremy-boo let's try to add this PR to main branch firstly, then decide if we would like to back port to v2.6.

And please give more details and explaination about this PR.

@Jeremy-boo
Copy link
Author

Ok, I'll cherry-pick this into the main branch and add some explanation

@Jeremy-boo Jeremy-boo closed this Dec 12, 2022
@Jeremy-boo
Copy link
Author

cherry-pick to main branch, this pr is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants