Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scanner_skip_update_pulltime property for system setting #18214

Merged
merged 1 commit into from Feb 22, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Feb 13, 2023

  1. Related backend PR Skip to update pull time and pull count for scanner robot account #17807
  2. This PR should be merged after Skip to update pull time and pull count for scanner robot account #17807

Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner February 13, 2023 05:49
@AllForNothing AllForNothing added release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.8.0 doc-impact Engineering issues that will require a change in user docs labels Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #18214 (4e09f2c) into main (4141d77) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18214      +/-   ##
==========================================
+ Coverage   67.11%   67.14%   +0.02%     
==========================================
  Files         971      971              
  Lines      105170   105171       +1     
  Branches     2579     2579              
==========================================
+ Hits        70583    70612      +29     
+ Misses      30844    30817      -27     
+ Partials     3743     3742       -1     
Flag Coverage Δ
unittests 67.14% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ide-nav/config/system/system-settings.component.ts 50.00% <ø> (ø)
...portal/src/app/base/left-side-nav/config/config.ts 100.00% <100.00%> (ø)
src/lib/cache/helper.go 75.00% <0.00%> (-8.34%) ⬇️
...-job/gc-page/gc/gc-history/gc-history.component.ts 40.69% <0.00%> (-5.82%) ⬇️
...audit-log-purge/history/purge-history.component.ts 40.69% <0.00%> (-5.82%) ⬇️
src/server/v2.0/handler/user.go 16.32% <0.00%> (+1.53%) ⬆️
...dashboard/schedule-card/schedule-card.component.ts 46.26% <0.00%> (+2.98%) ⬆️
src/common/utils/passports.go 90.19% <0.00%> (+3.92%) ⬆️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 36.00% <0.00%> (+4.00%) ⬆️
src/controller/event/topic.go 8.63% <0.00%> (+8.63%) ⬆️
... and 3 more

  1. Related backend PR goharbor#17807

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit c5640ac into goharbor:main Feb 22, 2023
sebglon pushed a commit to sebglon/harbor that referenced this pull request Mar 6, 2023
…r#18214)

1. Related backend PR goharbor#17807

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing deleted the skip-pull-time branch March 29, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-impact Engineering issues that will require a change in user docs release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants