Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword quota definitions based on user input #18512

Merged
merged 1 commit into from Apr 12, 2023

Conversation

OrlinVasilev
Copy link
Member

@OrlinVasilev OrlinVasilev commented Apr 11, 2023

Fixes: #17545

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fixes: goharbor#17545

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #18512 (a8cf84c) into main (d01125a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18512   +/-   ##
=======================================
  Coverage   67.36%   67.37%           
=======================================
  Files         984      984           
  Lines      106980   106980           
  Branches     2670     2670           
=======================================
+ Hits        72070    72079    +9     
+ Misses      31027    31017   -10     
- Partials     3883     3884    +1     
Flag Coverage Δ
unittests 67.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@OrlinVasilev OrlinVasilev added area/i18n Related to Translation changes. target/2.8.0 labels Apr 11, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 7edb447 into goharbor:main Apr 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. release-note/update Update or Fix target/2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harbor UI showing incorrect value of total storage consumption of a project
5 participants