Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position to vertical-align for copy button #18563

Merged
merged 1 commit into from Apr 20, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Apr 20, 2023

Fixes #17906

before:
image

after:
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fixes goharbor#17906

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #18563 (e323dc2) into main (c7cbf0f) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head e323dc2 differs from pull request most recent head aace5ba. Consider uploading reports for the commit aace5ba to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18563      +/-   ##
==========================================
+ Coverage   67.37%   67.41%   +0.03%     
==========================================
  Files         984      984              
  Lines      107010   107010              
  Branches     2670     2670              
==========================================
+ Hits        72100    72137      +37     
+ Misses      31033    30995      -38     
- Partials     3877     3878       +1     
Flag Coverage Δ
unittests 67.41% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@AllForNothing AllForNothing merged commit e793e24 into goharbor:main Apr 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy button is not centered vertically
6 participants