Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build db base image symlink error #18673

Merged
merged 1 commit into from May 12, 2023
Merged

Fix build db base image symlink error #18673

merged 1 commit into from May 12, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented May 12, 2023 •
edited

Fix #18672

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix build db base image symlink error
b81a91b 
Fix goharbor#18672

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/build release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.0 labels May 12, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner May 12, 2023 06:52
wy65701436
wy65701436 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 12, 2023 •
edited

Codecov Report

Merging #18673 (b81a91b) into main (f2fc0f6) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18673      +/-   ##
==========================================
+ Coverage   67.35%   67.39%   +0.03%     
==========================================
  Files         984      984              
  Lines      107022   107022              
  Branches     2669     2669              
==========================================
+ Hits        72088    72124      +36     
+ Misses      31054    31014      -40     
- Partials     3880     3884       +4
Flag Coverage Δ
unittests 67.39% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@YangJiao0817 YangJiao0817 merged commit cb8a3d0 into goharbor:main May 12, 2023
16 checks passed
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
@YangJiao0817 @WilfredAlmeida
Fix build db base image symlink error (goharbor#18673)
51a2ac1 
Fix goharbor#18672

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
@YangJiao0817 @WilfredAlmeida
Fix build db base image symlink error (goharbor#18673)
e0b2e8d 
Fix goharbor#18672

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@wy65701436 wy65701436

@zyyw zyyw

@YangJiao0817 YangJiao0817

Labels
area/build release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build db base image symlink error
4 participants
@YangJiao0817 @wy65701436 @zyyw @MinerYang