Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Fix setup-gcloud fails when building package #18683

Merged

Conversation

YangJiao0817
Copy link
Member

Fix #18681

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#18681

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/build release-note/infra Infra related changes e.g. release, test, ship etc... labels May 16, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner May 16, 2023 07:03
@YangJiao0817 YangJiao0817 changed the title Fix setup-gcloud fails when building package [cherry-pick]Fix setup-gcloud fails when building package May 16, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #18683 (ea54e50) into release-2.8.0 (48a2061) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.8.0   #18683   +/-   ##
==============================================
  Coverage          67.39%   67.39%           
==============================================
  Files                984      984           
  Lines             107006   107006           
  Branches            2670     2670           
==============================================
  Hits               72121    72121           
  Misses             31003    31003           
  Partials            3882     3882           
Flag Coverage Δ
unittests 67.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangJiao0817 YangJiao0817 merged commit 31baf31 into goharbor:release-2.8.0 May 16, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants