Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add Retain image last pull time API test case #18691

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented May 17, 2023

Fix #18618

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #18691 (f1e0f31) into release-2.8.0 (31baf31) will decrease coverage by 22.73%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.8.0   #18691       +/-   ##
==================================================
- Coverage          67.38%   44.66%   -22.73%     
==================================================
  Files                984      235      -749     
  Lines             107006    13089    -93917     
  Branches            2670     2670               
==================================================
- Hits               72105     5846    -66259     
+ Misses             31020     6950    -24070     
+ Partials            3881      293     -3588     
Flag Coverage Δ
unittests 44.66% <ø> (-22.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 753 files with indirect coverage changes

@YangJiao0817 YangJiao0817 changed the title Add Retain image last pull time API test case [cherry-pick]Add Retain image last pull time API test case May 17, 2023
@YangJiao0817 YangJiao0817 marked this pull request as draft May 17, 2023 08:57
Fix goharbor#18618

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 marked this pull request as ready for review May 18, 2023 06:24
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 6f51863 into goharbor:release-2.8.0 May 19, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants