Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add Retain image last pull time UI test case #18696

Merged

Conversation

YangJiao0817
Copy link
Member

Fix #18690

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#18690

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #18696 (92e7ddd) into release-2.8.0 (31baf31) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #18696      +/-   ##
=================================================
- Coverage          67.38%   67.35%   -0.03%     
=================================================
  Files                984      984              
  Lines             107006   107006              
  Branches            2670     2670              
=================================================
- Hits               72105    72074      -31     
- Misses             31020    31049      +29     
- Partials            3881     3883       +2     
Flag Coverage Δ
unittests 67.35% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

@YangJiao0817 YangJiao0817 merged commit 96cb84a into goharbor:release-2.8.0 May 19, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants