Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Use subtle.ConstantTimeCompare instead of compare directly #18712

Merged
merged 1 commit into from
May 23, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented May 22, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner May 22, 2023 06:47
@stonezdj stonezdj added the release-note/update Update or Fix label May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #18712 (c07f190) into release-2.8.0 (96cb84a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #18712      +/-   ##
=================================================
+ Coverage          67.35%   67.37%   +0.01%     
=================================================
  Files                984      984              
  Lines             107006   107006              
  Branches            2670     2670              
=================================================
+ Hits               72074    72094      +20     
+ Misses             31052    31030      -22     
- Partials            3880     3882       +2     
Flag Coverage Δ
unittests 67.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jobservice/api/authenticator.go 42.85% <100.00%> (ø)
src/registryctl/auth/secret.go 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 614683e into goharbor:release-2.8.0 May 23, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants