Add a tooltip for slack notification #18787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllForNothing
added
the
release-note/enhancement
|
@OrlinVasilev Can you help to review the English text for the added tooltip? |
Codecov Report
@@ Coverage Diff @@
## main #18787 +/- ##
==========================================
+ Coverage 67.34% 67.36% +0.02%
==========================================
Files 980 980
Lines 106864 106864
Branches 2665 2665
==========================================
+ Hits 71964 71992 +28
+ Misses 31032 31004 -28
Partials 3868 3868
Flags with carried forward coverage won't be shown. Click here to find out more. |
OrlinVasilev
previously requested changes
Jun 5, 2023
| @@ -432,7 +432,8 @@ | |||
| "EVENT_TYPE_REQUIRED": "Require at least one event type", | |||
| "PAYLOAD_FORMAT": "Payload Format", | |||
| "CLOUD_EVENT": "CloudEvents", | |||
| "PAYLOAD_DATA": "Payload Data" | |||
| "PAYLOAD_DATA": "Payload Data", | |||
| "SLACK_RATE_LIMIT": "Please be ware of the rate limits for Slack" | |||
There was a problem hiding this comment.
Suggested change
| "SLACK_RATE_LIMIT": "Please be ware of the rate limits for Slack" | |
| "SLACK_RATE_LIMIT": "Please be aware of Slack Rate Limits" |
| @@ -463,7 +463,8 @@ | |||
| "EVENT_TYPE_REQUIRED": "Pelo menos um tipo de evento é obrigatório", | |||
| "PAYLOAD_FORMAT": "Payload Format", | |||
| "CLOUD_EVENT": "CloudEvents", | |||
| "PAYLOAD_DATA": "Payload Data" | |||
| "PAYLOAD_DATA": "Payload Data", | |||
| "SLACK_RATE_LIMIT": "Please be ware of the rate limits for Slack" | |||
There was a problem hiding this comment.
Suggested change
| "SLACK_RATE_LIMIT": "Please be ware of the rate limits for Slack" | |
| "SLACK_RATE_LIMIT": "Please be aware of Slack Rate Limits" |
| @@ -430,7 +430,8 @@ | |||
| "EVENT_TYPE_REQUIRED": "请至少选择一种事件类型", | |||
| "PAYLOAD_FORMAT": "载荷形式", | |||
| "CLOUD_EVENT": "CloudEvents", | |||
| "PAYLOAD_DATA": "载荷数据" | |||
| "PAYLOAD_DATA": "载荷数据", | |||
| "SLACK_RATE_LIMIT": "请注意 Slack 的速率限制" | |||
There was a problem hiding this comment.
Suggested change
| "SLACK_RATE_LIMIT": "请注意 Slack 的速率限制" | |
| "SLACK_RATE_LIMIT": "Please be aware of Slack Rate Limits" |
|
@AllForNothing suggested changes |
AllForNothing
force-pushed
the
webhook-limit
branch
from
e2ec37d
to
5e5d189
Compare
|
@OrlinVasilev Thanks for the comments. PR updated |
AllForNothing
force-pushed
the
webhook-limit
branch
from
5e5d189
to
90a504a
Compare
1.Fixes goharbor#18507 2.Remind the users of Slack's rate limits Signed-off-by: AllForNothing <sshijun@vmware.com>
AllForNothing
force-pushed
the
webhook-limit
branch
from
90a504a
to
0d79168
Compare
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1.Fixes goharbor#18507 2.Remind the users of Slack's rate limits Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1.Fixes goharbor#18507 2.Remind the users of Slack's rate limits Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Fixes #18507
2.Remind the users of Slack's rate limits
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: