Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][2.8] fix: add retry on the caller of v2DeleteManifest instead within v2DeleteManifest #18803

Conversation

dkulchinsky
Copy link
Contributor

Comprehensive Summary of your change

Cherry pick to release 2.8 for #18662

Issue being fixed

Fixes #18381

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…eteManifest

Signed-off-by: Danny Kulchinsky <dkulchinsky@fastly.com>
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #18803 (93f1f58) into release-2.8.0 (0b55284) will decrease coverage by 3.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #18803      +/-   ##
=================================================
- Coverage          70.51%   67.36%   -3.15%     
=================================================
  Files                749      984     +235     
  Lines              93935   107025   +13090     
  Branches               0     2670    +2670     
=================================================
+ Hits               66237    72096    +5859     
- Misses             24111    31048    +6937     
- Partials            3587     3881     +294     
Flag Coverage Δ
unittests 67.36% <0.00%> (-3.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jobservice/job/impl/gc/garbage_collection.go 45.77% <0.00%> (-1.05%) ⬇️
src/jobservice/job/impl/gc/util.go 35.00% <0.00%> (+6.42%) ⬆️

... and 238 files with indirect coverage changes

@dkulchinsky
Copy link
Contributor Author

@wy65701436 @Vad1mo @zyyw

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit f8282a5 into goharbor:release-2.8.0 Jun 12, 2023
12 of 15 checks passed
@Vad1mo Vad1mo added the area/gc label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants