support nydus as a accessory #18953
Merged
support nydus as a accessory #18953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognize nydus image(with subject) as a kind of accessory and built the releationship with subject manifest Signed-off-by: wang yan <wangyan@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #18953 +/- ##
==========================================
- Coverage 67.42% 67.40% -0.02%
==========================================
Files 994 993 -1
Lines 108825 108768 -57
Branches 2747 2747
==========================================
- Hits 73376 73316 -60
- Misses 31511 31520 +9
+ Partials 3938 3932 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zyyw
reviewed
Jul 20, 2023
| layers := manifest.Layers | ||
| if len(layers) != 0 { | ||
| desc := layers[len(layers)-1] | ||
| if desc.Annotations == nil { |
There was a problem hiding this comment.
do we need tests cover this if branch
zyyw
reviewed
Jul 20, 2023
| _, hasAnno := desc.Annotations[layerAnnotationNydusBootstrap] | ||
| return hasAnno | ||
| } | ||
| return false |
There was a problem hiding this comment.
and also test case to cover this return false statement here.
zyyw
approved these changes
Jul 20, 2023
MinerYang
pushed a commit
that referenced
this pull request
Jul 24, 2023
Recognize nydus image(with subject) as a kind of accessory and built the releationship with subject manifest Signed-off-by: wang yan <wangyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize nydus image(with subject) as a kind of accessory and built the releationship with subject manifest
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: