Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config for job_loggers #18970

Merged
merged 3 commits into from Jul 24, 2023
Merged

feat: add config for job_loggers #18970

merged 3 commits into from Jul 24, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 21, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #18844

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #18970 (3ade8f2) into main (8ff095d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18970   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files         992      992           
  Lines      108725   108725           
  Branches     2747     2747           
=======================================
  Hits        73310    73310           
- Misses      31480    31483    +3     
+ Partials     3935     3932    -3     
Flag Coverage Δ
unittests 67.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 320c0d6 into goharbor:main Jul 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set jobLoggers config when install through docker-compose?
4 participants