-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix image name extraction #18992
fix image name extraction #18992
Conversation
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
@tkatkov Hi, thanks for your catch, could you please add the unit tests to cover the multiple cases for this function? |
@chlins tests added, thanks! |
Please fix the CI DCO, sign off your commit. e.g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18992 +/- ##
===========================================
- Coverage 67.56% 45.26% -22.30%
===========================================
Files 991 244 -747
Lines 109181 13345 -95836
Branches 2719 2724 +5
===========================================
- Hits 73768 6041 -67727
+ Misses 31449 7003 -24446
+ Partials 3964 301 -3663
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
It also could be 'library/bitnami/fluentd:1.13.3-debian-10-r0' so we need to split resource to only 2 parts - possible namespace and image name which may include slashes for example - namespace: library, image: bitnami/fluentd:1.13.3-debian-10-r0 Signed-off-by: Taras Katkov <tkatkov@gmail.com>
Adding namespace and resource extraction tests. Signed-off-by: Taras Katkov <tkatkov@gmail.com>
Signed-off-by: Taras Katkov <tkatkov@gmail.com>
It also could be 'library/bitnami/fluentd:1.13.3-debian-10-r0' so we need to split resource to only 2 parts - possible namespace and image name which may include slashes for example - namespace: library, image: bitnami/fluentd:1.13.3-debian-10-r0
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: