Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused code #19061

Merged
merged 4 commits into from Aug 29, 2023
Merged

Delete unused code #19061

merged 4 commits into from Aug 29, 2023

Conversation

liubin
Copy link
Contributor

@liubin liubin commented Jul 31, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

func GetRedisOfRegURL is not referenced.

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@liubin liubin requested a review from a team as a code owner July 31, 2023 09:26
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #19061 (b1f2b3a) into main (f3e4216) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19061      +/-   ##
==========================================
- Coverage   67.41%   67.41%   -0.01%     
==========================================
  Files         993      993              
  Lines      108896   108894       -2     
  Branches     2751     2751              
==========================================
- Hits        73416    73413       -3     
+ Misses      31533    31532       -1     
- Partials     3947     3949       +2     
Flag Coverage Δ
unittests 67.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lib/config/systemconfig.go 51.87% <ø> (+0.76%) ⬆️

... and 5 files with indirect coverage changes

@chlins chlins added the release-note/update Update or Fix label Aug 18, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

func GetRedisOfRegURL is not referenced.

Signed-off-by: bin liu <liubin0329@gmail.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 7ed1920 into goharbor:main Aug 29, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants