Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change JOB_ID to Task_ID #19127

Merged

Conversation

lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Aug 8, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

make terminology the same on ui.

Issue being fixed

Fixes #12443 #19126

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #19127 (9aea56d) into main (06139c1) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19127      +/-   ##
==========================================
- Coverage   44.85%   44.82%   -0.03%     
==========================================
  Files         244      244              
  Lines       13412    13412              
  Branches     2751     2751              
==========================================
- Hits         6016     6012       -4     
- Misses       7090     7097       +7     
+ Partials      306      303       -3     
Flag Coverage Δ
unittests 44.82% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@chlins
Copy link
Member

chlins commented Aug 18, 2023

@lengrongfu Thanks, please go through all the jobs related scenario, let's unify them to same. cc @AllForNothing

@AllForNothing
Copy link
Contributor

@lengrongfu Please do not modify the i18n files, you can modify the HTML files directly:
src/portal/src/app/base/left-side-nav/clearing-job/gc-page/gc/gc-history/gc-history.component.html
image
src/portal/src/app/base/left-side-nav/clearing-job/audit-log-purge/history/purge-history.component.html
image

change GC.JOB_ID to REPLICATION.TASK_ID

@lengrongfu
Copy link
Contributor Author

@lengrongfu Please do not modify the i18n files, you can modify the HTML files directly: src/portal/src/app/base/left-side-nav/clearing-job/gc-page/gc/gc-history/gc-history.component.html image src/portal/src/app/base/left-side-nav/clearing-job/audit-log-purge/history/purge-history.component.html image

change GC.JOB_ID to REPLICATION.TASK_ID

Thanks your tips.

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the feat/ui-cleanup-jobid-update branch from 816e843 to e8d2d1f Compare August 24, 2023 06:53
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the feat/ui-cleanup-jobid-update branch from e8d2d1f to 4fe0dc3 Compare August 25, 2023 01:20
Signed-off-by: lengrongfu <1275177125@qq.com>
@AllForNothing AllForNothing merged commit f3e4216 into goharbor:main Aug 25, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
5 participants