Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: fix typo for CONFIRM_SECRET #19140

Merged
merged 1 commit into from Aug 24, 2023
Merged

i18n: fix typo for CONFIRM_SECRET #19140

merged 1 commit into from Aug 24, 2023

Conversation

liubin
Copy link
Contributor

@liubin liubin commented Aug 9, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@liubin liubin requested a review from a team as a code owner August 9, 2023 09:12
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #19140 (4c9aa69) into main (298ecbb) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19140      +/-   ##
==========================================
- Coverage   67.40%   67.37%   -0.03%     
==========================================
  Files         993      993              
  Lines      108896   108896              
  Branches     2751     2751              
==========================================
- Hits        73400    73373      -27     
- Misses      31556    31579      +23     
- Partials     3940     3944       +4     
Flag Coverage Δ
unittests 67.37% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: bin liu <liubin0329@gmail.com>
@chlins chlins merged commit 23fd87a into goharbor:main Aug 24, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants