Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-tw (Traditional Chinese) locale #19161

Merged
merged 1 commit into from Aug 16, 2023

Conversation

PeterDaveHello
Copy link
Contributor

Improve zh-tw (Traditional Chinese) locale again. This is a follow up of #18608, and this time I try to refer to the en-us locale, also compare more references for the terms, although there are still some terms or strings not very perfect yet(I mean it's hard to be translated), hopefully the zh-tw language is at least more consistent and localized here now.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #19161 (4dbb9ab) into main (296e905) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19161      +/-   ##
==========================================
+ Coverage   67.40%   67.42%   +0.01%     
==========================================
  Files         993      993              
  Lines      108864   108864              
  Branches     2751     2751              
==========================================
+ Hits        73382    73402      +20     
+ Misses      31535    31516      -19     
+ Partials     3947     3946       -1     
Flag Coverage Δ
unittests 67.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@PeterDaveHello PeterDaveHello force-pushed the Update_zh-tw branch 2 times, most recently from de7fda9 to 5ccb49b Compare August 13, 2023 20:54
@AllForNothing AllForNothing added area/i18n Related to Translation changes. release-note/update Update or Fix labels Aug 14, 2023
@AllForNothing
Copy link
Contributor

@PeterDaveHello Very lovely to see a follow-up PR.
Also, can you invite someone who is a native speaker to help to review the changes? thanks!

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

Copy link

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share my POV

src/portal/src/i18n/lang/zh-tw-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/zh-tw-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/zh-tw-lang.json Show resolved Hide resolved
src/portal/src/i18n/lang/zh-tw-lang.json Outdated Show resolved Hide resolved
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve all the comments

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
@PeterDaveHello
Copy link
Contributor Author

@AllForNothing looks like we are good to go!

@AllForNothing AllForNothing merged commit 289d4e2 into goharbor:main Aug 16, 2023
12 checks passed
@PeterDaveHello PeterDaveHello deleted the Update_zh-tw branch August 16, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants